sveltekit blog #38
sveltekit blog #38
Conversation
|
Justin Hunter seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@niemyjski @ejsmith - When either of you have a minute can you take a look at this. The post is ready to go, but the JS client isn't working due to the error I mentioned in the PR. |
| /** @type {import('@sveltejs/kit').HandleError} */ | ||
| export async function handleError({ error, request }) { |
There was a problem hiding this comment.
might want to fix formatting here.
There was a problem hiding this comment.
How do you mean?
There was a problem hiding this comment.
Leading whitespace before export and the comment.
|
That's the error the clients getting and why it's not submitting. https://vitejs.dev/guide/dep-pre-bundling.html#the-why Should just work but it doesn't vitejs/vite#3024 |
|
We need to consider possibly moving off of stacktracejs/stacktrace.js#230, this will also cause us to lose sourcemaps supports as mozilla doesn't support esm :. Also svelte-kit doesn't support top level await so doing await on Exceptionless.startup won't work as |
F'd by the stacktrace stuff again. It definitely seems like we are getting our butts kicked here. We definitely have work to do. |
NOT READY TO MERGE - DRAFT STATE
Hey guys, here's the early rough draft for the SvelteKit post using their handleError hook.
I actually ran into a problem where importing the Exceptionless node package throws this error:
require is not definedUsing the browser package does nothing. No errors, but no events either. Could be the way I'm calling
startupbut wanted to see if you spotted anything obvious as you reviewed.